[DURACOM-449] update @4science_ng-dynamic-forms#5084
Conversation
tdonohue
added
bug
component: submission
1 APPROVAL
|
Just for the record, this appears to be the changes added to |
|
@strawburster: Since you reported this issue, would you be willing to give this a quick test to verify that it looks good on your end? |
|
Thank you @FrancescoMolinaro , the metadata looks perfect. I checked out this branch, installed the dependencies, and looked into the node_modules/@4science_ng-dynamic-forms/core/package.json and could find the link to the correct source code repository. I added one more comment I'd like to discuss about how to upgrade this dependency in the future. |
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @FrancescoMolinaro ! This looks good to me too. I also reviewed the changes made in 4Science/ng-dynamic-forms@8163f7b
As a future note, whenever we update this library, it'd be useful to link back to the changes made in the 4Science/ng-dynamic-forms project. That just makes it easier to review what changes are coming into DSpace. (That said, hopefully we'll find time to replace this library soon rather than later!)
github-project-automation
bot
moved this from 🙋 Needs Reviewers Assigned
to 👍 Reviewer Approved
in DSpace 10.0 Release
github-project-automation
bot
moved this from 👍 Reviewer Approved
to ✅ Done
in DSpace 10.0 Release
3 participants
References
Description
Update @4science_ng-dynamic-forms version.
Instructions for Reviewers
Run npm install and check that the metadata in the node_modules folder are corrected for the library.
List of changes in this PR:
Updated @4science_ng-dynamic-forms version.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.